Removing core transaction attempt context bound couchbase client factory rebased (#1449)

* Move ReactiveTransactionsWrapper tests into a new file

* (Temporarily?) disabling tests using CouchbaseTransactionOperation or TransactionalOperator

As I feel we should be removing/not-supporting these, and
on this branch I've broken them.

* Make all transaction tests call assertNotInTransaction

* Removing unused code

* Instead of binding the transaction AttemptContext to a
CouchbaseClientFactory, fetch it from ThreadLocalStorage
(or the reactive context) instead.

This allows a lot of simplifying:
* The non-trivial ReactiveCouchbaseClientUtils can be removed
* As can CoreTransactionAttemptContextBoundCouchbaseClientFactory

Also removing TransactionalSupport.one as it wasn't providing
as much DRY utility as I thought it would - only used in two
places.

This change won't compile on its own.  To reduce the complexity
of this patchset, the Reactive*OperationSupport changes will
go into a separate commit.

* Reactive*OperationSupport changes to support the previous commit.

* Fixing ReactiveRemoveByQuerySupport.

Both to support the changes to TransactionalSupport.
And to fix the TODO where the query resuls were
not being handled.

* Disabling a test

* Adding CouchbaseTransactionsWrapperTemplateIntegrationTests

* Another advantage of removing CoreTransactionAttemptContextBoundCouchbaseClientFactory
is we can remove Cluster and ClusterInterface.

* Adding CouchbaseReactiveTransactionsWrapperTemplateIntegrationTests

Some of these tests are currently failing - tracking down where the
issue is.

Author: programmatix

src/main/java/com/couchbase/client/java/Cluster.java

@@ -16,6 +16,7 @@
  */
 package com.couchbase.client.java.transactions;
 
+import java.io.IOException;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.time.Duration;
@@ -26,14 +27,20 @@
 import java.util.logging.Logger;
 
 import com.couchbase.client.core.annotation.Stability;
+import com.couchbase.client.core.deps.com.fasterxml.jackson.databind.node.ObjectNode;
+import com.couchbase.client.core.error.EncodingFailureException;
+import com.couchbase.client.core.json.Mapper;
+import com.couchbase.client.core.msg.query.QueryRequest;
 import com.couchbase.client.core.transaction.CoreTransactionAttemptContext;
 import com.couchbase.client.core.transaction.CoreTransactionContext;
 import com.couchbase.client.core.transaction.CoreTransactionsReactive;
 import com.couchbase.client.core.transaction.config.CoreMergedTransactionConfig;
 import com.couchbase.client.core.transaction.config.CoreTransactionOptions;
 import com.couchbase.client.core.transaction.log.CoreTransactionLogger;
 import com.couchbase.client.core.transaction.support.AttemptState;
+import com.couchbase.client.java.ReactiveScope;
 import com.couchbase.client.java.codec.JsonSerializer;
+import com.couchbase.client.java.json.JsonObject;
 import reactor.core.publisher.Mono;
 import reactor.util.annotation.Nullable;
 
@@ -131,4 +138,24 @@ public static TransactionResult run(Transactions transactions, Consumer<Transact
 		return reactive(transactions).runBlocking(transactionLogic, coreTransactionOptions);
 	}
 
+	// todo gp have C&Ped this from SDK, needs to be exposed properly in SDK
+	public static ObjectNode createTransactionOptions(final ReactiveScope scope,
+																				  final String statement,
+																				  final TransactionQueryOptions options) {
+		JsonObject json = JsonObject.create()
+				.put("statement", statement);
+		if (scope != null) {
+			json.put("query_context", QueryRequest.queryContext(scope.bucketName(), scope.name()));
+		}
+		if (options != null) {
+			options.builder().build().injectParams(json);
+		}
+		try {
+			ObjectNode opts = Mapper.reader().readValue(json.toBytes(), ObjectNode.class);
+			return opts;
+		} catch (IOException e) {
+			throw new EncodingFailureException(e);
+		}
+	}
+
 }

src/main/java/com/couchbase/client/java/ClusterInterface.java

@@ -17,7 +17,6 @@
 
 import com.couchbase.client.core.transaction.CoreTransactionAttemptContext;
 import com.couchbase.client.java.Cluster;
-import com.couchbase.client.java.ClusterInterface;
 import com.couchbase.client.java.Collection;
 import com.couchbase.client.java.Scope;
 import com.couchbase.client.java.transactions.config.TransactionOptions;
@@ -42,7 +41,7 @@ public interface ReactiveCouchbaseClientFactory /*extends CodecRegistryProvider*
 	/**
 	 * Provides access to the managed SDK {@link Cluster} reference.
 	 */
-	ClusterInterface getCluster();
+	Cluster getCluster();
 
 	/**
 	 * Provides access to the managed SDK {@link Scope} reference
@@ -91,12 +90,6 @@ public interface ReactiveCouchbaseClientFactory /*extends CodecRegistryProvider*
 
 	ReactiveCouchbaseResourceHolder getResourceHolder(TransactionOptions options, CoreTransactionAttemptContext ctx);
 
-	/*
-	 * (non-Javadoc)
-	 * @see org.springframework.data.mongodb.ReactiveMongoDatabaseFactory#withSession(com.mongodb.session.ClientSession)
-	 */
-	ReactiveCouchbaseClientFactory withCore(ReactiveCouchbaseResourceHolder core);
-
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.mongodb.ReactiveMongoDatabaseFactory#with(com.mongodb.session.ClientSession)