Datacouch 1145 transaction support (#1448)

* Move CouchbaseTransactionalOperator to use SLF4J, same as
rest of the code.

* Handle all propagation levels

* Adding new tests for repository calls inside @transactional

One test is failure due to what looks like a bug elsewhere.

* Rename CouchbaseTransactionalIntegrationTests, and check
after each test that we're not in a transaction.

* Remove unnecessary methods From ReactiveCouchbaseClientFactory.

Also rationalized naming of methods and other changes.

* Cleanup of test classes.

* Removing unused classes

(Reducing the cognitive burden)

* Removing version from CouchbaseDocument

This change was done previously - it must have slipped back in
a merge.

* Adding and removing TODOs

* Adding and removing TODOs

* DRYing CouchbaseTransactionalPropagationIntegrationTests

* Check propagation tests retry as expected

* Tidy up PersonWithoutVersion to the minimum required

* Removing unused code

This should all be non-destructive.  Just removing code IntelliJ
declares unused.  Intent is to make it easier to figure out
how the CoreTransactionAttemptContext TLS is working.

* Adding tests for @transactional removeByQuery and findByQuery

Failing as they aren't being executed transactionally - investigating why.

Co-authored-by: Michael Reiche <[email protected]>

Author: programmatix

src/main/java/com/couchbase/client/java/transactions/AttemptContextReactiveAccessor.java

@@ -66,22 +66,6 @@ public static ReactiveTransactionAttemptContext reactive(TransactionAttemptConte
 		return new ReactiveTransactionAttemptContext(getCore(atr), serializer);
 	}
 
-	public static TransactionAttemptContext blocking(ReactiveTransactionAttemptContext atr) {
-		JsonSerializer serializer;
-		try {
-			Field field = ReactiveTransactionAttemptContext.class.getDeclaredField("serializer");
-			field.setAccessible(true);
-			serializer = (JsonSerializer) field.get(atr);
-		} catch (Throwable err) {
-			throw new RuntimeException(err);
-		}
-			return new TransactionAttemptContext(getCore(atr), serializer);
-	}
-
-	public static CoreTransactionLogger getLogger(ReactiveTransactionAttemptContext attemptContextReactive) {
-		return attemptContextReactive.logger();
-	}
-
 	public static CoreTransactionLogger getLogger(TransactionAttemptContext attemptContextReactive) {
 		return attemptContextReactive.logger();
 	}
@@ -100,6 +84,7 @@ public static CoreTransactionAttemptContext newCoreTranactionAttemptContext(Reac
 			throw new RuntimeException(err);
 		}
 
+		// todo gpx options need to be loaded from Cluster and TransactionOptions (from TransactionsWrapper)
 		CoreTransactionOptions perConfig = new CoreTransactionOptions(Optional.empty(), Optional.empty(), Optional.empty(),
 				Optional.of(Duration.ofMinutes(10)), Optional.empty(), Optional.empty());
 
@@ -115,16 +100,6 @@ public static CoreTransactionAttemptContext newCoreTranactionAttemptContext(Reac
 		return coreTransactionAttemptContext;
 	}
 
-	private static Duration now() {
-		return Duration.of(System.nanoTime(), ChronoUnit.NANOS);
-	}
-
-	public static ReactiveTransactionAttemptContext from(CoreTransactionAttemptContext coreTransactionAttemptContext,
-			JsonSerializer serializer) {
-		TransactionAttemptContext tac = new TransactionAttemptContext(coreTransactionAttemptContext, serializer);
-		return reactive(tac);
-	}
-
 	public static CoreTransactionAttemptContext getCore(ReactiveTransactionAttemptContext atr) {
 		CoreTransactionAttemptContext coreTransactionsReactive;
 		try {
@@ -147,61 +122,11 @@ public static CoreTransactionAttemptContext getCore(TransactionAttemptContext at
 		}
 	}
 
-	public static Mono<Void> implicitCommit(ReactiveTransactionAttemptContext atr, boolean b) {
-		CoreTransactionAttemptContext coreTransactionsReactive = getCore(atr);
-		try {
-			// getDeclaredMethod() does not find it (because of primitive arg?)
-			// CoreTransactionAttemptContext.class.getDeclaredMethod("implicitCommit", Boolean.class);
-			Method[] methods = CoreTransactionAttemptContext.class.getDeclaredMethods();
-			Method method = null;
-			for (Method m : methods) {
-				if (m.getName().equals("implicitCommit")) {
-					method = m;
-					break;
-				}
-			}
-			if (method == null) {
-				throw new RuntimeException("did not find implicitCommit method");
-			}
-			method.setAccessible(true);
-			return (Mono<Void>) method.invoke(coreTransactionsReactive, b);
-		} catch (Throwable err) {
-			throw new RuntimeException(err);
-		}
-
-	}
-
-	public static AttemptState getState(ReactiveTransactionAttemptContext atr) {
-		CoreTransactionAttemptContext coreTransactionsReactive = getCore(atr);
-		try {
-			Field field = CoreTransactionAttemptContext.class.getDeclaredField("state");
-			field.setAccessible(true);
-			return (AttemptState) field.get(coreTransactionsReactive);
-		} catch (Throwable err) {
-			throw new RuntimeException(err);
-		}
-	}
-
 	public static ReactiveTransactionAttemptContext createReactiveTransactionAttemptContext(
 			CoreTransactionAttemptContext core, JsonSerializer jsonSerializer) {
 		return new ReactiveTransactionAttemptContext(core, jsonSerializer);
 	}
 
-	public static CoreTransactionsReactive getCoreTransactionsReactive(ReactiveTransactions transactions) {
-		try {
-			Field field = ReactiveTransactions.class.getDeclaredField("internal");
-			field.setAccessible(true);
-			return (CoreTransactionsReactive) field.get(transactions);
-		} catch (Throwable err) {
-			throw new RuntimeException(err);
-		}
-	}
-
-	public static TransactionAttemptContext newTransactionAttemptContext(CoreTransactionAttemptContext ctx,
-			JsonSerializer jsonSerializer) {
-		return new TransactionAttemptContext(ctx, jsonSerializer);
-	}
-
 	public static TransactionResult run(Transactions transactions, Consumer<TransactionAttemptContext> transactionLogic, CoreTransactionOptions coreTransactionOptions) {
 		return reactive(transactions).runBlocking(transactionLogic, coreTransactionOptions);
 	}