AbstractPersistentProperty now considers the owner for equals. #2973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a difference when a property is declared in a superclass of two entities. In such a case the property is the same, but the owner is different. Closes #2972 See spring-projects/spring-data-relational#1657
schauder
force-pushed
the
issue/relational-1657-bad-cached-aggregate-path
branch
from
1687ac3 to
213d89d
Compare
mp911de
approved these changes
Nov 8, 2023
|
Please also backport to 3.1.x |
|
As per our conversation, LGTM. |
schauder
added a commit
that referenced
this pull request
Nov 8, 2023
This makes a difference when a property is declared in a superclass of two entities. In such a case the property is the same, but the owner is different. Closes #2972 Original pull request #2973 See spring-projects/spring-data-relational#1657
schauder
added a commit
that referenced
this pull request
Nov 8, 2023
This makes a difference when a property is declared in a superclass of two entities. In such a case the property is the same, but the owner is different. Closes #2972 Original pull request #2973 See spring-projects/spring-data-relational#1657
|
Merged and backported to 3.1.x |
schauder
added a commit
that referenced
this pull request
Nov 12, 2023
This reverts commit 633d125. The change caused build failures for Spring Data JDBC. See #2972 Original pull request #2973 See spring-projects/spring-data-relational#1657
schauder
added a commit
that referenced
this pull request
Nov 12, 2023
This reverts commit 93913b0. The change caused build failures for Spring Data JDBC. See #2972 Original pull request #2973 See spring-projects/spring-data-relational#1657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a difference when a property is declared in a superclass of two entities.
In such a case the property is the same, but the owner is different.
Closes #2972
See spring-projects/spring-data-relational#1657
As discussed yesterday I build Spring Data JPA and Spring Data Rest based on this change.
The builds ran without a problem.
I also verify that it actually resolves spring-projects/spring-data-relational#1657