Possible ClassCast exception in ResultProcessor

[michael-simons]

This fragment

spring-data-commons/src/main/java/org/springframework/data/repository/query/ResultProcessor.java

Lines 146 to 148 in ee004b0

	if (source instanceof Slice && method.isPageQuery() || method.isSliceQuery()) {
	return (T) ((Slice<?>) source).map(converter::convert);
	}

assumes that if the method is a slice method, the non converted result is already a slice, which does fail if it is a plain collection.

[michael-simons]

Ok, might we used in wrong in SDN6, but still find it irritating.

[mp911de]

Good catch, it's indeed a potential bug.

[michael-simons]

Thank you!

We now use the result processor in such a way that we pass in a Slice with unprocessed results as compared to before when we passed in the raw raw result (raw list, raw object) from the database. This works for us as expected and was no big deal to change, but I didn't realize the need just through the API or JavaDoc upfront.