fix missing trailing slash in spring.resources.static-locations

[szantopeter]

If the value of spring.resources.static-locations is not ending with a trailing slash then no resources are loaded from the specified folder. The current code already provided a solution for adding a trailing slash, but that processing was done in the wrong place, so I moved it to a location where it really takes effect.

[szantopeter]

@snicoll @philwebb what do you think about this PR?

[philwebb]

that processing was done in the wrong place, so I moved it to a location where it really takes effect.

@szantopeter Can you provide a bit more background on why the existing code isn't working for you? Do you have a sample application you can share that shows the problem?

[szantopeter]

@philwebb I created a sample here https://github.com/szantopeter/spring-boot-static-locations There are two tests, both should pass, but one fails. The only difference between them is a trailing slash

[philwebb]

Thanks.

[philwebb]

We might be able to shift that logic to setStaticLocations

[wilkinsona]

@szantopeter Thanks very much for the PR. As suggested by @philwebb, we've taken a slightly different approach to fixing the problem. Please see ad62905 for details.

[szantopeter]

@wilkinsona it took me some efforts to identify the bug and find the solution so I was hoping that I will have a commit in Spring Boot, but apart from that final solution is good as well!

[wilkinsona]

@szantopeter Sorry. We would normally have taken a bit more time to give you a chance to make the suggested updates but we're trying to finish off 1.5.4 which is due on Thursday. Please don't misinterpret the PR not being merged as us not appreciating your efforts.