-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Environment Conversion Fix (Complex) #9258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment Conversion Fix (Complex) #9258
Conversation
|
@ethanrubinson Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
When converting one environment to another as much of the original environment’s configuration should be copied over as possible. This fix copies the default profiles and the property resolver configuration which was not occurring previously.
79ee47b to
4917720
Compare
|
@ethanrubinson Thank you for signing the Contributor License Agreement! |
|
The license signing failed so I re-commited. |
|
Duplicates #9259 |
|
@ethanrubinson no idea what you mean by "license signing failed" but there is no reason to open another pull request. The check will update itself once you've signed the CLA. |
|
@snicoll This wasn't a duplicate. See issue #9246 for more information. This is the more complex version of the other PR which uses reflection to copy over as much of the original environment's configuration as possible. We had discussed that this was a very hacky fix so to also submit a PR that just fixes the base case (and unblocks us). The license signing did fail (the PR had an X), so I just force re-commited this commit which kicks off the PR builders again. Can you please re-open this PR? |
|
Ok I got confused. The two PRs have the exact same name... |
|
Thanks for the PR, @ethanrubinson. We're going to use the simpler, non-reflective solution that just addresses your use case. |
When converting one environment to another as much of the original
environment’s configuration should be copied over as possible. This fix
copies the default profiles and the property resolver configuration
which was not occurring previously.
#9246