Skip to content

Conversation

@ethanrubinson
Copy link
Contributor

When converting one environment to another as much of the original
environment’s configuration should be copied over as possible. This fix
copies the default profiles and the property resolver configuration
which was not occurring previously.

#9246

@pivotal-issuemaster
Copy link

@ethanrubinson Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 18, 2017
When converting one environment to another as much of the original
environment’s configuration should be copied over as possible. This fix
copies the default profiles and the property resolver configuration
which was not occurring previously.
@ethanrubinson ethanrubinson force-pushed the 1.5.x-env-conversion-fix-complex branch from 79ee47b to 4917720 Compare May 18, 2017 04:49
@pivotal-issuemaster
Copy link

@ethanrubinson Thank you for signing the Contributor License Agreement!

@ethanrubinson
Copy link
Contributor Author

The license signing failed so I re-commited.

@snicoll
Copy link
Member

snicoll commented May 19, 2017

Duplicates #9259

@snicoll snicoll closed this May 19, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels May 19, 2017
@snicoll
Copy link
Member

snicoll commented May 19, 2017

@ethanrubinson no idea what you mean by "license signing failed" but there is no reason to open another pull request. The check will update itself once you've signed the CLA.

@ethanrubinson
Copy link
Contributor Author

ethanrubinson commented May 19, 2017

@snicoll This wasn't a duplicate. See issue #9246 for more information. This is the more complex version of the other PR which uses reflection to copy over as much of the original environment's configuration as possible. We had discussed that this was a very hacky fix so to also submit a PR that just fixes the base case (and unblocks us).

The license signing did fail (the PR had an X), so I just force re-commited this commit which kicks off the PR builders again. Can you please re-open this PR?

@snicoll
Copy link
Member

snicoll commented May 19, 2017

Ok I got confused. The two PRs have the exact same name...

@snicoll snicoll reopened this May 19, 2017
@ethanrubinson ethanrubinson changed the title Environment Conversion Fix Environment Conversion Fix (Complex) May 19, 2017
@wilkinsona wilkinsona added status: waiting-for-triage An issue we've not yet triaged and removed status: duplicate A duplicate of another issue labels May 24, 2017
@wilkinsona
Copy link
Member

Thanks for the PR, @ethanrubinson. We're going to use the simpler, non-reflective solution that just addresses your use case.

@wilkinsona wilkinsona closed this Jun 7, 2017
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants