You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines ConfigurationPropertiesReflectionHintsProcessor Java bean properties handling in order to register reflection hints only for getters and setters, not for all methods.
It avoids including unconditionally method like SpringApplication#load which in turn avoids shipping BeanDefinitionLoader and related transitively used classes in the native image.
The gain is significant: it allows to remove up to 700 classes (when no XML parser is used elsewhere) and to reduce the memory footprint by 2M of RSS.
Thanks @sdeleuze. Is there any good way to unit test this? The changes look quite subtle and I'm worried we might accidentally revert back at some point and not notice that we've made things worse.
This commit refines ConfigurationPropertiesReflectionHintsProcessor
Java bean properties handling in order to register reflection hints
only for getters and setters, not for all methods.
It avoids including unconditionally method like SpringApplication#load
which in turn avoids shipping BeanDefinitionLoader and related transitively
used classes in the native image.
The gain is significant: it allows to remove up to 700 classes
(when no XML parser is used elsewhere) and to reduce the memory footprint
by 2M of RSS.
More related to https://github.com/spring-projects/spring-aot-smoke-tests but potentially complementary to the tests provided in this PR : we could use -H:ReportAnalysisForbiddenType=org.springframework.boot.BeanDefinitionLoader native image parameter to fails the native build of let say command-line-runner sample if this class is in the resulting native image (it should not). Once this PR merged, I can submit a PR on smoke tests side to add this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
status: on-hold
This commit refines
ConfigurationPropertiesReflectionHintsProcessorJava bean properties handling in order to register reflection hints only for getters and setters, not for all methods.It avoids including unconditionally method like
SpringApplication#loadwhich in turn avoids shippingBeanDefinitionLoaderand related transitively used classes in the native image.The gain is significant: it allows to remove up to 700 classes (when no XML parser is used elsewhere) and to reduce the memory footprint by 2M of RSS.