Start building against Micrometer 1.10.0-M5 and Micrometer Tracing 1.0.0-M8 snapshots #32048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
# Conflicts: # spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfiguration.java # spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfigurationTests.java
I'm not sure if the config is right though
jonatan-ivanov
commented
Aug 19, 2022
| @@ -1410,7 +1410,7 @@ bom { | |||
| ] | |||
| } | |||
| } | |||
| library("Spring Batch", "5.0.0-M4") { | |||
| library("Spring Batch", "5.0.0-SNAPSHOT") { | |||
There was a problem hiding this comment.
This should be revisited before merging this PR.
...g/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfiguration.java
Show resolved
Hide resolved
wilkinsona
added
type: dependency-upgrade
wilkinsona
added
type: task
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Sep 6, 2022
See gh-32048 Co-authored-by: Marcin Grzejszczak <[email protected]>
|
Thanks for the PR, @jonatan-ivanov and @marcingrzejszczak. As part of merging and squashing this, I reworked things a little to move to the latest snapshots rather than the older milestones. |
This was referenced Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on a not yet released version of Spring Batch (
5.0.0-M5) since Boot depends on Batch M4 which uses Micrometer 1.10.0-M3 (batch tests are failing because of this).Related: micrometer-metrics/micrometer#3342