Take MethodType into account to deduce main application class #31828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
See #31701 |
philwebb
added
type: bug
|
I don't think this is a bug. The code that was contributed in #31701 is equivalent to what we had before. This suggestion improves things in a way that wasn't possible before. |
Yes, It's just an improvement. |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 22, 2022
wilkinsona
added a commit
that referenced
this pull request
Jul 22, 2022
|
Thanks very much, @quaff. |
|
This change breaks in native image, I've created #31858 |
snicoll
added
the
status: declined
|
For the reason above, I've reverted this change. We can follow-up in #31858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.