Skip to content

@ConditionalOnProperty meta annotation with @AliasFor does not work #30505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

@ConditionalOnProperty meta annotation with @AliasFor does not work #30505

wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

@terminux terminux commented Apr 2, 2022

Fixes gh-24968

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2022
@mhalbritter
Copy link
Contributor

Hey @terminux, thanks for the PR. Andy left a comment on the issue. Did you take this into account?

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Apr 4, 2022
@terminux
Copy link
Contributor Author

terminux commented Apr 4, 2022

Thanks for your reply @mhalbritter. This PR was submitted based on Andy's comment. It's essentially a variant of AnnotatedTypeMetadata.getAllAnnotationAttributes(String) , simplifying some logic and accounting for attribute overriding.

I didn't modify the code in metaAndDirectAnnotationConditionDoesNotMatchWhenOnlyDirectPropertyIsSet and this unit test passed.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 4, 2022
@wilkinsona wilkinsona self-assigned this May 4, 2022
@wilkinsona wilkinsona mentioned this pull request May 5, 2022
Closed
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels May 5, 2022
@wilkinsona wilkinsona added this to the 2.5.14 milestone May 5, 2022
wilkinsona pushed a commit that referenced this pull request May 5, 2022
@terminux @wilkinsona
Fix ConditionalOnProperty when used in an aliased composed annotation
dc57ad5 
See gh-30505
wilkinsona added a commit that referenced this pull request May 5, 2022
@wilkinsona
Polish "Fix ConditionalOnProperty when used in an aliased composed an…
6d4f023 
…notation"

See gh-30505
@wilkinsona wilkinsona closed this in 8cd3b86 May 5, 2022
@wilkinsona
Copy link
Member

Thanks very much, @terminux.

@wilkinsona wilkinsona mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.14
Development

Successfully merging this pull request may close these issues.
4 participants
@terminux @mhalbritter @wilkinsona @spring-projects-issues