Skip to content

Fix MongoMetricsAutoConfigurationTests #25952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Apr 9, 2021

This PR fixes the following:

  • nested ContextConsumer
  • missing .with(MetricsRun.simple())

They could make the tests pass unintentionally.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 9, 2021
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 9, 2021
@snicoll snicoll added this to the 2.5.0-RC1 milestone Apr 9, 2021
@snicoll snicoll self-assigned this Apr 9, 2021
snicoll pushed a commit that referenced this pull request Apr 9, 2021
@snicoll snicoll closed this in c398418 Apr 9, 2021
@izeye izeye deleted the fix-MongoMetricsAutoConfigurationTests branch April 9, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants