Increase test coverage on Java 16 #25809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
pushed a commit
that referenced
this pull request
Mar 26, 2021
wilkinsona
added
type: task
|
Thanks very much, @dreis2211. That's considerably fewer |
humaolin
pushed a commit
to humaolin/spring-boot
that referenced
this pull request
May 7, 2022
Closes spring-projectsgh-25809 (cherry picked from commit d9da663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after a chat with @wilkinsona about Gradle 7 in 2.5.x it became apparent that it might be a little late to do this once it's out. As only Gradle 7 is supporting Java 16 at the moment, I went ahead and removed the remaining
maximumCompatibleJavaVersionconfigurations from the build in favor of this PR, which mainly includes moreDisabledForJreRangeusages.Let me know what you think.
Cheers,
Christoph