Extract XML examples from Maven plugin adoc files #25534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…ect> Fix custom-image-name-pom.xml with proper image name instead of env info
snicoll
changed the title
|
@scottfrederick Got any feedback on this pr? Anything I can fix? |
scottfrederick
added
type: task
scottfrederick
pushed a commit
that referenced
this pull request
Mar 31, 2021
scottfrederick
added a commit
that referenced
this pull request
Mar 31, 2021
|
@robert-smith-911 Thanks very much for another great contribution. This has been merged along with a polishing commit to pick up a change that was done since you submitted the PR and fix up a few small things. |
|
@scottfrederick Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to issue #25376 by pulling out all xml snippets from the Spring Boot Maven Plugin Documentation (adoc files) into their own runnable xml files.
Please let me know if you have any edits you suggest, I took the liberty of setting the tabsize per snippet, and also with the xml file names. If these need to change, please advise.