Correct javadoc for ON_PARAM to accurately describe its behavior #25480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maruoovv Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@maruoovv Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the pull request. Instead of updating the javadoc, I wonder if we should update the implementation so that it behaves as documented. Let's see what the rest of the team thinks. |
wilkinsona
added
the
for: team-attention
|
We'll go with the Javadoc fix. Thanks for the PR! |
philwebb
added
type: documentation
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Mar 11, 2021
|
Thanks very much for making your first contribution to Spring Boot, @maruoovv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to correct javadoc
When set to IncludeStacktrace.ON_PARAM, IncludeAttribute.ON_PARAM, parameters does not only work when the value is "true", they work on any values that other than "false"