Fix multi-release JAR test on JDK 15 #21605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
Ah! I don't think we should do that as we'll have to do a check every time we need to support a new JDK anyway. |
|
I agree - I just wanted to mention it at least once. ;) |
Closed
snicoll
pushed a commit
that referenced
this pull request
Jun 5, 2020
dreis2211
added a commit
to dreis2211/spring-boot
that referenced
this pull request
Sep 22, 2020
Backport of 54f93e9 See spring-projectsgh-23433 See spring-projectsgh-21605
dreis2211
added a commit
to dreis2211/spring-boot
that referenced
this pull request
Sep 22, 2020
Backport of 54f93e9 See spring-projectsgh-23433 See spring-projectsgh-21605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just did a quick for #21604 to see if everything works on JDK 15 with the custom
buildJavaHomeproperty I introduced for JDK 14.This PR fixes a test failure in
JarFileTests.multiReleaseEntry.I'm wondering if we should add some entries in advance already for JDK 16 & 17 ;-)
Cheers,
Christoph