Skip to content

Fix ClientHttpConnectorConfigurationTests.shouldApplyHttpClientMapper() #21390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix ClientHttpConnectorConfigurationTests.shouldApplyHttpClientMapper() #21390

wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented May 11, 2020

This PR fixes ClientHttpConnectorConfigurationTests.shouldApplyHttpClientMapper() as it doesn't test that the mapper is called as intended.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 11, 2020
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 12, 2020
@snicoll snicoll self-assigned this May 12, 2020
@snicoll snicoll added this to the 2.3.0 milestone May 12, 2020
@snicoll
Copy link
Member

snicoll commented May 12, 2020

Good catch, thanks again @izeye!

snicoll pushed a commit that referenced this pull request May 12, 2020
@izeye @snicoll
Fix ClientHttpConnectorConfigurationTests.shouldApplyHttpClientMapper()
6022d4c 
See gh-21390
@snicoll snicoll closed this in 64aac04 May 12, 2020
@izeye izeye deleted the fix-called branch May 12, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@izeye @snicoll @spring-projects-issues