Change call to createClassLoader(URL) from 'super' to 'this' #20851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecutableArchiveLauncher.createClassLoader(Iterator) calls createClassLoader(URL) method with 'super' effectively removing any chance the later method could be overriden and successfully called without overriding both methods.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
mbhave
pushed a commit
that referenced
this pull request
Apr 6, 2020
ExecutableArchiveLauncher.createClassLoader(Iterator) calls createClassLoader(URL) method with 'super'. This means overriding createClassLoader(URL) is not possible without also overriding createClassLoader(Iterator). The switch to 'this' enables that. See gh-20851
Contributor
|
Thanks @olegz. This has now been merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutableArchiveLauncher.createClassLoader(Iterator) calls createClassLoader(URL) method with 'super' effectively removing any chance the later method could be overriden and successfully called without overriding both methods.