Skip to content

Conversation

@dreis2211
Copy link
Contributor

Hi,

this PR should add a CI job for Java 14 and therefore closes #20147 . Again - as the CI topics are extremely hard to test for me locally, feel free to decline the PR or forgive me if things are not working as they were intended.

Eventually, when there is a Gradle version that works with JDK 14, we can clean things up again. For the time being, the spring-boot-gradle-plugin tests are excluded from the build.

In order to have a green build, the following two prior PRs need to be merged:

Let me know what you think.
Cheers,
Christoph


pushd git-repo > /dev/null
./gradlew -Dorg.gradle.internal.launcher.welcomeMessageEnabled=false --no-daemon --max-workers=4 -PdeploymentRepository=${repository} build publishAllPublicationsToDeploymentRepository
if [[ -d /opt/openjdk-secondary ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with this block here, but as said: this can be cleaned up when there is a Gradle version that works with JDK 14

plan:
- get: spring-boot-jdk14-ci-image
- get: git-repo
trigger: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be set to true - I was unsure if I should do that from the start. Let me know if I should change it already.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 6, 2020
@dreis2211
Copy link
Contributor Author

Updated the PR to use the first GA release of JDK 14

@snicoll
Copy link
Member

snicoll commented Mar 18, 2020

@dreis2211 we've decided to go with Gradle 6.3 RC2 so the secondary JDK is no longer necessary. I have a feeling though that this infrastructure can be useful going forward. I am going to revert that piece of the PR to create an extra pipeline that's similar to the others.

@snicoll snicoll mentioned this pull request Mar 18, 2020
@snicoll snicoll self-assigned this Mar 18, 2020
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2020
@snicoll snicoll added this to the 2.3.0.M4 milestone Mar 18, 2020
@dreis2211
Copy link
Contributor Author

dreis2211 commented Mar 18, 2020

@snicoll Makes sense. We can probably even revert the testJavaHome and buildJavaHome parameters in case we're on a Gradle version that works with JDK 14. Similar to the secondary JDK stuff, this might get relevant again for future upgrades ;)

snicoll pushed a commit that referenced this pull request Mar 18, 2020
snicoll added a commit that referenced this pull request Mar 18, 2020
@snicoll snicoll closed this in 961611a Mar 18, 2020
@snicoll
Copy link
Member

snicoll commented Mar 18, 2020

@dreis2211 I've just reverted the part of the PR that was using the infrastructure. I think that testJavaHome and buildJavaHome are generally useful and don't need to be reverted. Let's see what happens on CI now :)

Let me know if something feels odd in the polish. Thanks again!

snicoll added a commit that referenced this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Java 14 CI

3 participants