-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Add Java 14 CI #20413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java 14 CI #20413
Conversation
|
|
||
| pushd git-repo > /dev/null | ||
| ./gradlew -Dorg.gradle.internal.launcher.welcomeMessageEnabled=false --no-daemon --max-workers=4 -PdeploymentRepository=${repository} build publishAllPublicationsToDeploymentRepository | ||
| if [[ -d /opt/openjdk-secondary ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super happy with this block here, but as said: this can be cleaned up when there is a Gradle version that works with JDK 14
| plan: | ||
| - get: spring-boot-jdk14-ci-image | ||
| - get: git-repo | ||
| trigger: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be set to true - I was unsure if I should do that from the start. Let me know if I should change it already.
|
Updated the PR to use the first GA release of JDK 14 |
|
@dreis2211 we've decided to go with Gradle 6.3 RC2 so the secondary JDK is no longer necessary. I have a feeling though that this infrastructure can be useful going forward. I am going to revert that piece of the PR to create an extra pipeline that's similar to the others. |
|
@snicoll Makes sense. We can probably even revert the |
|
@dreis2211 I've just reverted the part of the PR that was using the infrastructure. I think that Let me know if something feels odd in the polish. Thanks again! |
Hi,
this PR should add a CI job for Java 14 and therefore closes #20147 . Again - as the CI topics are extremely hard to test for me locally, feel free to decline the PR or forgive me if things are not working as they were intended.
Eventually, when there is a Gradle version that works with JDK 14, we can clean things up again. For the time being, the spring-boot-gradle-plugin tests are excluded from the build.
In order to have a green build, the following two prior PRs need to be merged:
Let me know what you think.
Cheers,
Christoph