Skip to content

Conversation

@sjlzcj
Copy link

@sjlzcj sjlzcj commented Mar 5, 2020

…and add username and password in ClientConfiguration when username or password is not null

…and add username and password in ClientConfiguration when username or password is not null
@pivotal-issuemaster
Copy link

@sjlzcj Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 5, 2020
@pivotal-issuemaster
Copy link

@sjlzcj Thank you for signing the Contributor License Agreement!

@sjlzcj sjlzcj closed this Mar 5, 2020
@sjlzcj
Copy link
Author

sjlzcj commented Mar 5, 2020

Add maxInMemorySize property for ReactiveRestClientAutoConfiguration and add username and password in ClientConfiguration when username or password is not null

@sjlzcj sjlzcj reopened this Mar 5, 2020
@wilkinsona
Copy link
Member

We already have a proposal for making the max in-memory size configurable. It is currently scheduled for inclusion in Spring Boot 2.3.

The username and password are already applied by the existing auto-configuration:

map.from(properties.getUsername()).whenHasText().to((username) -> {
HttpHeaders headers = new HttpHeaders();
headers.setBasicAuth(username, properties.getPassword());
builder.withDefaultHeaders(headers);
});

Thanks anyway for your pull request.

@wilkinsona wilkinsona closed this Mar 5, 2020
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 5, 2020
@snicoll snicoll mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate A duplicate of another issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants