Skip to content

RestTemplateExchangeTags does not handle non-standard status codes #17991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

RestTemplateExchangeTags does not handle non-standard status codes #17991

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Aug 29, 2019

This PR applies changes similar to gh-17695 but for RestTemplate.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2019
@wilkinsona wilkinsona changed the title Improve handling of non-standard status codes in RestTemplate metrics RestTemplateExchangeTags does not handle non-standard status codes Aug 29, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Aug 29, 2019
@wilkinsona
Copy link
Member

I thought about the RestTemplate case when working on #17695 and then completely forgot about it. Thanks for stopping this half from falling through the cracks, @izeye.

@wilkinsona wilkinsona self-assigned this Aug 29, 2019
@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.2.x Aug 29, 2019
wilkinsona pushed a commit that referenced this pull request Aug 29, 2019
@izeye @wilkinsona
Improve handling of non-standard status codes in RestTemplate metrics
1acff41 
See gh-17991
wilkinsona added a commit that referenced this pull request Aug 29, 2019
@wilkinsona
Polish "Improve handling of non-standard status codes in RestTemplate…
0217de4 
… metrics"

See gh-17991
@wilkinsona
Copy link
Member

Thanks again, @izeye. The proposed changes have been merged into master.

@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.0.M6 Aug 29, 2019
@izeye izeye deleted the rest-template-status-code branch August 29, 2019 12:52
@dreis2211 dreis2211 mentioned this pull request Aug 29, 2019
Closed
pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Aug 29, 2019
@izeye @pull
Improve handling of non-standard status codes in RestTemplate metrics
e27fc91 
See spring-projectsgh-17991
pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Aug 29, 2019
@wilkinsona @pull
Polish "Improve handling of non-standard status codes in RestTemplate…
63288a4 
… metrics"

See spring-projectsgh-17991
izeye added a commit to izeye/micrometer that referenced this pull request Aug 29, 2019
@izeye
Improve handling of non-standard status codes in RestTemplate metrics
24dec67 
This commit backports spring-projects/spring-boot#17991.
@izeye izeye mentioned this pull request Aug 29, 2019
Merged
shakuzen pushed a commit to micrometer-metrics/micrometer that referenced this pull request Aug 29, 2019
@izeye @shakuzen
Improve handling of non-standard status codes in RestTemplate metrics (…
537fc5c 
…#1564)

This commit backports spring-projects/spring-boot#17991.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@spencergibb spencergibb spencergibb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@wilkinsona wilkinsona

Labels
type: bug A general bug
Projects
None yet
Milestone
2.2.0.M6
Development

Successfully merging this pull request may close these issues.
4 participants
@izeye @wilkinsona @spencergibb @spring-projects-issues