Add official link on Heroku Deployment #16719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current doc’s instructions on how to deploy spring boot apps to Heroku is not kind enough. https://docs.spring.io/spring-boot/docs/2.1.4.RELEASE/reference/htmlsingle/#cloud-deployment-heroku “The most common deployment workflow for Heroku deployments is to git push the code to production, as shown in the following example: Your application should now be up and running on Heroku.” Heroku’s official guide on how to do so is very thorough. https://devcenter.heroku.com/articles/deploying-spring-boot-apps-to-heroku Therefore, it will be nice if a link to it can be added. P.S. I think that the snippet of git push heroku master does not provide much information and is just taking up space.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: documentation
Member
|
Thanks! Linking to the official docs is great idea. |
snicoll
pushed a commit
that referenced
this pull request
May 6, 2019
snicoll
added a commit
that referenced
this pull request
May 6, 2019
* pr/16719: Polish "Add link to Heroku article" Add link to Heroku article
Member
|
@Tetsuya3850 thanks for the PR. I've polished it in d8f1bd3 as the link in your PR was in markdown format (and wouldn't have rendered properly). |
Contributor
Author
|
Ah! I wasn't aware of that format requirement. Thank you for the polish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current doc’s instructions on how to deploy spring boot apps to Heroku is not kind enough.
https://docs.spring.io/spring-boot/docs/2.1.4.RELEASE/reference/htmlsingle/#cloud-deployment-heroku
“The most common deployment workflow for Heroku deployments is to git push the code to production, as shown in the following example: Your application should now be up and running on Heroku.”
Heroku’s official guide on how to do so is very thorough.
https://devcenter.heroku.com/articles/deploying-spring-boot-apps-to-heroku
Therefore, it will be nice if a link to it can be added.
P.S. I think that the snippet of git push heroku master does not provide much information and is just taking up space.