Skip to content

Conversation

@maciejwalkowiak
Copy link
Contributor

Since Spring Boot comes with support for JOOQ it would be also nice if the sql logging group also include it.

After this change, setting logging.level.sql=debug and executing query through jOOQ will result entries like one below in logs:

Executing query          : select "public"."property_ad"."id", "public"."property_ad"."bathrooms", "public"."property_ad"."price", "public"."property_ad"."rooms", "public"."property_ad"."surface_area" from "public"."property_ad"
Fetched result           : +----+---------+-----+-----+------------+
                         : |  id|bathrooms|price|rooms|surface_area|
                         : +----+---------+-----+-----+------------+
                         : |   1|        1|   40|    3|         120|
                         : |   2|        2|   80|    5|         150|
                         : +----+---------+-----+-----+------------+
Fetched row(s)           : 2

Pinging @lukaseder in case I missed something.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2019
@lukaseder
Copy link
Contributor

Pinging @lukaseder in case I missed something.

That sounds very reasonable. The default Settings.executeLogging value is true, so this configuration should indeed suffice.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 29, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Apr 29, 2019
@wilkinsona wilkinsona changed the title Add jOOQ to SQL logging group. Add jOOQ to SQL logging group Apr 29, 2019
@snicoll snicoll self-assigned this Apr 30, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M3 Apr 30, 2019
snicoll pushed a commit that referenced this pull request Apr 30, 2019
@snicoll snicoll closed this in 0595768 Apr 30, 2019
snicoll added a commit that referenced this pull request Apr 30, 2019
* pr/16678:
  Polish "Add jOOQ to SQL logging group"
  Add jOOQ to SQL logging group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants