Skip to content

Deal with several holes in the article #16065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Deal with several holes in the article #16065

wants to merge 2 commits into from

Conversation

caojiele
Copy link

@caojiele caojiele commented Mar 1, 2019

These holes has a total of three places:
1.{spring-boot-docs-current}, there is no jump links.
2.{github-code}[getinvolved], there is no jump links.
3. * Running your code, the lack of punctuation":".

Add punctuation  “ : ”
Add the link address to several annotations.
@pivotal-issuemaster
Copy link

@caojiele Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spencergibb
Copy link
Member

Those links get properly resolved when the documentation is built. See https://docs.spring.io/spring-boot/docs/2.1.3.RELEASE/reference/htmlsingle/#boot-documentation-about

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 1, 2019
@pivotal-issuemaster
Copy link

@caojiele Thank you for signing the Contributor License Agreement!

@caojiele
Copy link
Author

caojiele commented Mar 1, 2019

Those links get properly resolved when the documentation is built. See https://docs.spring.io/spring-boot/docs/2.1.3.RELEASE/reference/htmlsingle/#boot-documentation-about

ok,tks.

@wilkinsona
Copy link
Member

Thanks anyway, @caojiele. As you may recall, the missing : has already been taken care of in #16056.

@wilkinsona wilkinsona closed this Mar 1, 2019
@wilkinsona wilkinsona added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 1, 2019
@caojiele
Copy link
Author

caojiele commented Mar 2, 2019

Thanks anyway, @caojiele. As you may recall, the missing : has already been taken care of in #16056.
OK, thanks for reminding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants