Skip to content

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Aug 9, 2018

This PR makes server.tomcat.max-swallow-size align with Tomcat's default value as I couldn't find any good reason to diverge from Tomcat's default value in the related issue (#6669), PR (#13966) and commits (0d40c5a, a8b9718). If there's any good reason to diverge which I missed, feel free to close this PR.

See https://tomcat.apache.org/tomcat-9.0-doc/config/http.html

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 9, 2018
@snicoll
Copy link
Member

snicoll commented Aug 9, 2018

If there's any good reason to diverge which I missed, feel free to close this PR.

Oh there is a perfectly good reason, my maths is foobar 😓- I read 2 * 1024 * 1024 and thought I was very smart to use 4096 🙄

Thank you again Johnny !

@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 9, 2018
@snicoll snicoll self-assigned this Aug 9, 2018
@snicoll snicoll added type: task A general task and removed type: bug A general bug labels Aug 9, 2018
@snicoll snicoll added this to the 2.1.0.M2 milestone Aug 9, 2018
@snicoll snicoll closed this in b90113a Aug 9, 2018
snicoll added a commit that referenced this pull request Aug 9, 2018
* pr/14025:
  Align server.tomcat.max-swallow-size with Tomcat's default value
@izeye izeye deleted the max-swallow-size-default-value branch August 9, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants