Spring Active Profiles inconsistencies with --spring.profiles.active and SpringApplicationBuilder

[sstarcher]

new SpringApplicationBuilder.profiles does not seem to be reloading correctly.
Command line --spring.profiles.active=A
new SpringApplicationBuilder.profiles("C")
version is A and ActiveProfiles are "A,C"
I would expect version to be C.

Command line --spring.profiles.active=C
new SpringApplicationBuilder.profiles("A")
version is C and ActiveProfiles are "C,A"
Works as expected and I get a version of C.

When not using --spring.profiles.active on the command line and only using the SpringApplicationBuilder setting the profile does not seem to affect the value of version when spring.profiles.active is set in the yml file.

spring.profiles.active: B

---
spring.profiles: A
version: A

---
spring.profiles: B
version: B

---
spring.profiles: C
version: C

---

[dsyer]

I think the A,C vs C,A behaviour is what I expect. It has to be order dependent: if there are 2 active profiles that both define the "version" property, we have to pick one somehow. If you can justify the choice of the opposite order then we might be able to change it. But it sounds like you don't think it should be order dependent (which I don't understand).

setting the profile does not seem to affect the value of version when spring.profiles.active is set in the yml file

Is that a separate issue. I'm confused.

[sstarcher]

I see I misunderstood the mechanism you were using to load everything. My assumption was as follows. If multiple profiles were active it would scan the documents and load each profile section as it occurred. Which in that case the profiles that were active would not be order dependent and the actual result would be dependent on if spring.profiles: A was above or below spring.profiles: C.

So is the actual mechanism that it loads the profiles in reverse order so the if they all define the same values the very first profile takes precedence and that the order of the spring.profiles sections in the yml document do not change the actual order.

[sstarcher]

Actually I think this is part of my confusion.
SpringApplicationBuilder.profile("A","B","C") would result in version=C and all 3 a,b,c profiles being processed. And Environment.getActiveProfiles would give [A,B,C].

Keeping SpringApplicationBuilder.profile("A","B","C") and also setting --spring.profiles.active=B would result in version=B and all 3 a,b,c profiles being processed, but Environment.getActiveProfiles would give [B,A,C].

When using just SpringApplicationBuilder.profile() and comparing it to Environment.getActiveProfiles it would seem that everything is loaded in order one at a time and the last profile would take precedence.

But when using both SpringApplicationBuilder.profile() it seems it and Environment.getActiveProfiles seem to be out of order.

What seems to be happening is SpringApplicationBuilder.profile is being processed and afterwards --spring.profiles.active is being processed, but the ordering in Environment.getActiveProfiles does not match up with the actual load ordering.

[dsyer]

I can't reproduce your result (as I understand it), but I do agree that there are some surprising consequences of ordering of profiles, so I'm going to write some tests and see if I can decide on a pragmatic outcome.