-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Closed
Labels
theme: observabilityIssues related to observabilityIssues related to observabilitytype: bugA general bugA general bug
Milestone
Description
In WavefrontTracingAutoConfiguration, it defines a WavefrontSpanHandler bean.
This passes an empty collection to the redMetricsCustomTagKeys in the constructor.
Lines 62 to 69 in 0e67fbc
| @Bean | |
| @ConditionalOnMissingBean | |
| @ConditionalOnBean(WavefrontSender.class) | |
| WavefrontSpanHandler wavefrontSpanHandler(WavefrontProperties properties, WavefrontSender wavefrontSender, | |
| SpanMetrics spanMetrics, ApplicationTags applicationTags) { | |
| return new WavefrontSpanHandler(properties.getSender().getMaxQueueSize(), wavefrontSender, spanMetrics, | |
| properties.getSourceOrDefault(), applicationTags, Collections.emptySet()); | |
| } |
Per this documentation in Wavefront, the redMetricsCustomTagKeys should be populated by the wavefront.tracing.red-metrics-custom-tag-keys property.
I believe this bean definition is the corresponding part for the property.
So, what the doc mentioned to work, I think populated values need to be passed to redMetricsCustomTagKeys rather than an empty set.
Metadata
Metadata
Assignees
Labels
theme: observabilityIssues related to observabilityIssues related to observabilitytype: bugA general bugA general bug