Add builder for JpaItemWriter #602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mminella
reviewed
May 17, 2018
| } | ||
| catch (IllegalStateException ise) { | ||
| assertEquals("Incorrect message", "EntityManagerFactory must be provided", ise.getMessage()); | ||
| } |
There was a problem hiding this comment.
If an IllegalStateException isn't thrown, your test will still pass.
There was a problem hiding this comment.
Fixed. In this case, we should do the same for the hibernate item writer builder: https://github.com/spring-projects/spring-batch/blob/master/spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/builder/HibernateItemWriterBuilderTests.java#L90
Do you agree?
Resolves BATCH-2714.
|
LGTM. Rebased and merged as 69b32e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATCH-2714.