BATCH-2624: Chunk oriented step builders must validate that an ItemWriter is provided #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aligns the XML and Java based validations. When using XML to configure a chunk oriented step both an ItemReader and ItemWriter are requied. However when using Java based configuration the ItemWriter is optional if an ItemProcessor is present. Having no ItemWriter and only an ItemProcessor lead to strange results in one of our batch jobs, which was accidentily configured without an ItemProcessor. Related: BATCH-1520 Fixes: BATCH-2624
fmbenhassine
changed the title
mminella
reviewed
Apr 5, 2018
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2006-2014 the original author or authors. | |||
| * Copyright 2006-2017 the original author or authors. | |||
| @@ -135,6 +140,28 @@ public void setUp() throws Exception { | |||
| repository.add(stepExecution); | |||
| } | |||
|
|
|||
| @Test() | |||
There was a problem hiding this comment.
You don't need the parens if they are not used...
| factory.getObject(); | ||
| } | ||
|
|
||
| @Test() |
There was a problem hiding this comment.
You don't need the parens if they are not used...
| @@ -92,6 +97,28 @@ public void testMandatoryProperties() throws Exception { | |||
| new SimpleStepFactoryBean<String, String>().getObject(); | |||
| } | |||
|
|
|||
| @Test() | |||
There was a problem hiding this comment.
You don't need the parens if they are not used...
| factory.getObject(); | ||
| } | ||
|
|
||
| @Test() |
There was a problem hiding this comment.
You don't need the parens if they are not used...
|
Thanks for the review. I updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases #491 on the master branch and adds a test on the mandatory item writer.
I took the opportunity to also add a test on the mandatory item reader.