GH-4900: Fix RecordFieldSetMapper for empty record #4947
Closed
+27
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add initialization for constructorParameterNames, constructorParameterTypes for empty record case. - add TC for empty record case. Signed-off-by: Seungyong Hong <[email protected]>
|
Hi @fmbenhassine, would you mind considering this PR also for 6.0.0-M3, including providing feedback to #4900 (comment)? To finalize #4864, I'll need to know that outcome to refine the nullability of |
|
LGTM 👍 Rebased and merged as 43a323f. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #4900.
RecordFieldSetMapper can't handle 'empty record' case.
Changes
Notes
This issue is not confirmed by maintainer.
Waiting for confirm and review.