Skip to content

Incorrect remote chunking sample in documentation [BATCH-2721] #886

@spring-projects-issues

Description

@spring-projects-issues

Mahmoud Ben Hassine opened BATCH-2721 and commented

There are some minor errors in the remote chunking section of the documentation:

  • First, the diagram shows an item reader on the worker side, but in remote chunking, the reading happens on the master side and items are sent over the wire
  • The Step4 label is better if it was Step3
  • The chunkJob method of the code example takes an ItemReader as parameter but uses a method call/reference in the stepBuilderFactory.reader method
  • The chunkHandler bean is not needed on the master side
  • According to the documentation, the middleware has to be durable, but in the code example, we declare the JMS subscription as non durable: .configureListenerContainer(c -> c.subscriptionDurable(false))
  • The term "slave" is better renamed to "worker"

It would be also great to add a remote chunking sample to the spring-batch-samples module.


Affects: 4.0.1

Referenced from: pull request #603, and commits 026bbe0, d69e46e

Backported to: 4.1.0.M1, 4.0.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions