Fix DefaultRowSet implementation #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbot59
force-pushed
the
bugfix/default-row-set
branch
from
d10f735 to
dea1cfe
Compare
|
Thanks for your contribution and the fix. Could you add a test as well for this case? Although the fix seems simple I would like to guard it with a test . |
cbot59
force-pushed
the
bugfix/default-row-set
branch
from
13a27ae to
49aab36
Compare
|
@mdeinum test added |
mdeinum
approved these changes
Aug 18, 2025
mdeinum
force-pushed
the
bugfix/default-row-set
branch
from
964befa to
af50406
Compare
… than column names length Signed-off-by: Rivaldi <[email protected]>
- Adhere to rules from Checkstyle - Simplify implementation - Fix bug in other test-case (apparent after simplifying the implementation) Signed-off-by: Marten Deinum <[email protected]>
mdeinum
force-pushed
the
bugfix/default-row-set
branch
from
af50406 to
288c398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
currentRowlength exceeds column names provided onRowSetMetaDatathen assigningpropswould causeArrayIndexOutOfBoundsExceptionto be thrown