Auto-config: Retries for network exceptions #4576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the retry configuration to include `ResourceAccessException` and, if available, `WebClientRequestException` to handle transient network errors during AI service calls more effectively. This improves the resilience of the application when interacting with potentially unstable AI services. Signed-off-by: Seunggyu Lee <[email protected]>
Signed-off-by: Seunggyu Lee <[email protected]>
seungy0
force-pushed
the
network-exception-retry
branch
from
63b7c5c to
9d1eb67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #4567
Auto-configured retry template now aligns with builder defaults by retrying on pre-response network exceptions. Previously, network connectivity errors like connection timeouts and connection refused were not retried in the auto-configuration path, causing inconsistent resilience behavior compared to the builder defaults.
Problem
RetryTemplateonly retried onTransientAiException(HTTP-status-based)ResourceAccessException,WebClientRequestException) bypassedResponseErrorHandlerand were not retriedSolution
ResourceAccessExceptionto retryable exceptions in auto-configuredRetryTemplateWebClientRequestExceptionretry support when WebFlux is present (via reflection)ResponseErrorHandlerlogicImpact
✅ Aligns auto-config retry behavior with
RetryUtils.DEFAULT_RETRY_TEMPLATE✅ Retries pre-response network exceptions (connection timeouts, connection refused)
✅ Optional WebFlux support without hard dependency
✅ Maintains existing retry behavior for
TransientAiException✅ No breaking changes - purely additive retry behavior
✅ Comprehensive unit tests added for all scenarios