Skip to content

chore: remove unnecessary null checks #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unnecessary null checks #4104

wants to merge 1 commit into from
+1 −1

Conversation

csbiy
Copy link

@csbiy csbiy commented Aug 10, 2025

This PR removes unnecessary null checks from the StTemplateRenderer class to simplify the code and avoid redundant validation.

Changes

  • Removed redundant null checks on template variables map keys in the apply method.
  • Simplified validation logic by eliminating defensive checks that are unlikely to occur.

@csbiy
chore: remove unnecessary null checks in template variable validation
4851e5f 
- Simplified code by dropping redundant null checks

Signed-off-by: csbiy <[email protected]>
Signed-off-by: csbiy <[email protected]>
sunyuhan1998
sunyuhan1998 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sunyuhan1998 sunyuhan1998 sunyuhan1998 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csbiy @sunyuhan1998