Skip to content

Upgrade to IntelliJ IDEA 2021.2 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Sep 29, 2021 · 3 comments
Closed

Upgrade to IntelliJ IDEA 2021.2 #294

snicoll opened this issue Sep 29, 2021 · 3 comments
Assignees
Milestone

Comments

@snicoll
Copy link
Contributor

snicoll commented Sep 29, 2021

I haven't tried but it looks like it is broken again.

@wilkinsona
Copy link
Contributor

There's an API for external formatters on its way, but I don't think it's quite ready yet as the issue's still in progress.

@bclozel
Copy link
Member

bclozel commented Sep 29, 2021

I'm not seeing any particular exception during plugin install or IDE startup.

But I'm not 100% sure the plugin works as expected. Formatting an existing class in a project changes the formatting in a way that ./gradlew format is not happy with. IDEA logs aren't saying much besides the following:

2021-09-29 12:06:44,651 [  85395]   INFO - cloudConfig.CloudConfigManager - === InstallPlugin: PluginDescriptor(name=Spring Javaformat, id=spring-javaformat, descriptorPath=plugin.xml, path=~/Downloads/spring-javaformat-intellij-idea-plugin-0.0.28.jar, version=0.0.28, package=null) ===
2021-09-29 12:06:44,663 [  85407]   INFO - il.indexing.FileBasedIndexImpl - START INDEX SHUTDOWN
2021-09-29 12:06:44,838 [  85582]   INFO - tellij.psi.stubs.StubIndexImpl - StubIndexExtension-s were unloaded
2021-09-29 12:06:45,186 [  85930]   INFO - il.indexing.FileBasedIndexImpl - END INDEX SHUTDOWN
2021-09-29 12:06:45,202 [  85946]   INFO - lij.ide.plugins.DynamicPlugins - Plugin spring-javaformat loaded without restart in 548 ms

Happy to help here with more diagnostics.

@philwebb philwebb added this to the 0.0.29 milestone Sep 29, 2021
@wilkinsona
Copy link
Contributor

wilkinsona commented Sep 30, 2021

This has broken CI, I think because we've lost some IntelliJ modules that were being installed locally and then depended on by spring-javaformat-intellij-idea-plugin. It passed locally as the local repo was "polluted" with those modules from previous builds.

@wilkinsona wilkinsona reopened this Sep 30, 2021
@wilkinsona wilkinsona self-assigned this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants