Ensure message headers are still mutable after interceptor is called #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2016 13:27
Some components in Spring assume (perhaps wrongly) that a channel interceptor will not convert a mutable message into an immutable one, and they continue to modify the headers dowstream. We can dosge the issue of whether this is right or wrong by keeping the message headers mutable, just in case. It would probably be better to refactor the SpanInjector so that it works with something other than the MessageBuilder, but we can defer doing that in favour of this smaller change that works. Adds a test for mutability. Also tested with the gs-messaging-stomp-websocket guide from spring.io. Fixes spring-cloudgh-276
When wrapping a ThreadPoolTaskExecutor in a bean postprocessor we should take care that the delegate gets the lifecycle callbacks from the container. Otherwise when it is first used, the thread pool will not have been initialized, resulting in an exception. (Can't believe this ever actually worked)
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components in Spring assume (perhaps wrongly) that a channel
interceptor will not convert a mutable message into an immutable one, and
they continue to modify the headers dowstream. We can dosge the issue of
whether this is right or wrong by keeping the message headers mutable, just
in case.