Permits Actuator endpoints to depend on HttpTracing #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unusual to inject HttpTracing into an actuator endpoint vs an end-user api such as `Tracer` or `SpanCustomizer`. However, we decided to allow this and so need a test to prove this continues to work. Fixes #1679
Codecov Report
@@ Coverage Diff @@
## 2.2.x #1680 +/- ##
============================================
- Coverage 59.28% 59.26% -0.02%
- Complexity 879 880 +1
============================================
Files 162 162
Lines 4787 4790 +3
Branches 556 557 +1
============================================
+ Hits 2838 2839 +1
- Misses 1686 1688 +2
Partials 263 263
Continue to review full report at Codecov.
|
added 2 commits
July 8, 2020 14:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actuator endpoints are queried to make the default skip pattern. There's an
edge case where actuator endpoints indirectly reference the still constructing
HttpTracing bean. Ex: an instrumented client could cause a cyclic dep.
This optimizes for the opposite: that custom actuator endpoints are not in
use. This allows configuration to be eagerly parsed, allowing any errors to
surface earlier. In the case there is a cyclic dep, this parsing becomes lazy,
deferring any errors creating the skip pattern.
Fixes #1679