Optional/Null parameter used within @SpanTag #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedla
force-pushed
the
null-spantag-parameter
branch
from
fa9dac9 to
62225e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
============================================
+ Coverage 59.21% 59.40% +0.18%
- Complexity 768 771 +3
============================================
Files 134 134
Lines 4146 4148 +2
Branches 489 491 +2
============================================
+ Hits 2455 2464 +9
+ Misses 1466 1458 -8
- Partials 225 226 +1
Continue to review full report at Codecov.
|
|
Lgtm can you apply this against 2.2.x branch? |
|
Hey @bedla , could you please apply this PR against 2.2.x branch? |
|
No problem, you mean both branches?
(I am currently at vacations)
Dne po 29. 6. 2020 15:15 uživatel Marcin Grzejszczak <
[email protected]> napsal:
… Hey @bedla <https://github.com/bedla> , could you please apply this PR
against 2.2.x branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPWRV2SY7XEIRKHCMO5ZDRZCHWTANCNFSM4OD7GNMQ>
.
|
|
Ah I didn't know you're on holidays. I've merged your code to master and backported it to 2.2.x branch. Great work and enjoy your holidays :) |
|
i am back :) thx for merge and sorry for inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that when I have request parameter that is optional (
nullwhen controller method invoked) with combination with@SpanTag, tag is handled incorrectly.I have created PR that solves it. Please look at tests to see usecases (see
NullParameterController).What do you think?
Thx,
Ivos