Skip to content

Conversation

@jwcarman
Copy link
Contributor

No description provided.

@pivotal-issuemaster
Copy link

@jwcarman Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@jwcarman Thank you for signing the Contributor License Agreement!

@codecov-io
Copy link

Codecov Report

Merging #1183 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1183      +/-   ##
============================================
+ Coverage     69.75%   69.77%   +0.01%     
- Complexity      772      773       +1     
============================================
  Files           142      142              
  Lines          3525     3527       +2     
  Branches        386      387       +1     
============================================
+ Hits           2459     2461       +2     
  Misses          843      843              
  Partials        223      223
Impacted Files Coverage Δ Complexity Δ
...loud/sleuth/autoconfig/TraceAutoConfiguration.java 96% <100%> (+0.16%) 21 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cdaf5...bb39bdd. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #1183 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1183      +/-   ##
============================================
- Coverage     69.75%   69.65%   -0.11%     
- Complexity      772      773       +1     
============================================
  Files           142      142              
  Lines          3525     3526       +1     
  Branches        386      387       +1     
============================================
- Hits           2459     2456       -3     
- Misses          843      848       +5     
+ Partials        223      222       -1
Impacted Files Coverage Δ Complexity Δ
...loud/sleuth/autoconfig/TraceAutoConfiguration.java 95.91% <100%> (+0.08%) 21 <0> (+1) ⬆️
...ing/TracingConnectionFactoryBeanPostProcessor.java 64.28% <0%> (-3.58%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cdaf5...8e003c8. Read the comment docs.

@jwcarman jwcarman changed the title 1182: The serviceName is not being resolved properly The serviceName is not being resolved properly Jan 15, 2019
@marcingrzejszczak marcingrzejszczak merged commit 89ca7d7 into spring-cloud:master Jan 15, 2019
@marcingrzejszczak
Copy link
Contributor

Congrats @jwcarman on your first contribution :)

@jwcarman jwcarman deleted the issue-1182 branch January 15, 2019 15:43
@jwcarman
Copy link
Contributor Author

W00T! Thanks for the merge. Looking forward to the 2.1.0.RELEASE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants