Skip to content

Conversation

@marcingrzejszczak
Copy link
Contributor

fixes gh-1162

@marcingrzejszczak
Copy link
Contributor Author

@shakuzen @adriancole

@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #1175 into master will decrease coverage by 0.21%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1175      +/-   ##
===========================================
- Coverage     69.91%   69.7%   -0.22%     
- Complexity      757     764       +7     
===========================================
  Files           138     140       +2     
  Lines          3444    3456      +12     
  Branches        373     373              
===========================================
+ Hits           2408    2409       +1     
- Misses          822     833      +11     
  Partials        214     214
Impacted Files Coverage Δ Complexity Δ
.../cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java 100% <ø> (ø) 5 <0> (ø) ⬇️
...mework/cloud/sleuth/sampler/SamplerProperties.java 100% <100%> (ø) 5 <2> (+2) ⬆️
...work/cloud/sleuth/sampler/RateLimitingSampler.java 60% <60%> (ø) 2 <2> (?)
...cloud/sleuth/sampler/SamplerAutoConfiguration.java 62.5% <62.5%> (ø) 3 <3> (?)
...ing/TracingConnectionFactoryBeanPostProcessor.java 67.85% <0%> (-5.36%) 6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dc5be...6149307. Read the comment docs.

@codefromthecrypt
Copy link
Contributor

cc also @devinsba @anuraaga

@marcingrzejszczak
Copy link
Contributor Author

marcingrzejszczak commented Jan 7, 2019

fixed via 2579e78

@marcingrzejszczak marcingrzejszczak deleted the issues_#1162_ratelimit branch January 7, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring RateLimitingSampler via properties

4 participants