Skip to content

Support loadbalancer lifecycle #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2020
Merged

Support loadbalancer lifecycle #418

merged 3 commits into from
Oct 27, 2020

Conversation

@OlgaMaciaszek
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek commented Oct 23, 2020

No description provided.

@OlgaMaciaszek OlgaMaciaszek added the enhancement New feature or request label Oct 23, 2020
@OlgaMaciaszek OlgaMaciaszek added this to the 3.0.0-M5 milestone Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #418 into master will increase coverage by 0.03%.
The diff coverage is 78.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #418      +/-   ##
============================================
+ Coverage     78.30%   78.34%   +0.03%     
- Complexity      382      390       +8     
============================================
  Files            47       48       +1     
  Lines          1392     1422      +30     
  Branches        207      209       +2     
============================================
+ Hits           1090     1114      +24     
- Misses          200      208       +8     
+ Partials        102      100       -2
Impacted Files Coverage Δ Complexity Δ
...adbalancer/FeignLoadBalancerAutoConfiguration.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...loud/openfeign/loadbalancer/LoadBalancerUtils.java 46.15% <46.15%> (ø) 4.00 <4.00> (?)
.../loadbalancer/FeignBlockingLoadBalancerClient.java 94.11% <90.00%> (+1.80%) 9.00 <2.00> (+2.00)
...ncer/RetryableFeignBlockingLoadBalancerClient.java 68.29% <90.00%> (+5.27%) 15.00 <2.00> (+2.00)
...alancer/DefaultFeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...ncer/HttpClientFeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...balancer/OkHttpFeignLoadBalancerConfiguration.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)

ryanjbaxter
ryanjbaxter approved these changes Oct 26, 2020
View reviewed changes
...g/springframework/cloud/openfeign/loadbalancer/RetryableFeignBlockingLoadBalancerClient.java Outdated
});
}

private Response executeWithLoadBalancerLifecycleProcessing(Request.Options options, Request feignRequest,
Copy link
Contributor

@ryanjbaxter ryanjbaxter Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this logic be shared between the clients?

Copy link
Collaborator Author

@OlgaMaciaszek OlgaMaciaszek Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move it to a utility class.

@OlgaMaciaszek OlgaMaciaszek merged commit 6649c86 into master Oct 27, 2020
@OlgaMaciaszek OlgaMaciaszek deleted the support-loadbalancer-lifecycle branch December 2, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanjbaxter ryanjbaxter ryanjbaxter approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.0.0-M5

Development

Successfully merging this pull request may close these issues.

3 participants

@OlgaMaciaszek @ryanjbaxter