closer to jdk-17 changes #1074
closer to jdk-17 changes #1074
Conversation
pom.xml
Outdated
| <plugin> | ||
| <groupId>io.spring.javaformat</groupId> | ||
| <artifactId>spring-javaformat-maven-plugin</artifactId> | ||
| <!-- Remove version when : https://github.com/spring-cloud/spring-cloud-build/pull/235 is integrated and released --> |
There was a problem hiding this comment.
I will take care of this one also, when it is fixed over there
There was a problem hiding this comment.
Let me know when the PR is ready and we can do this all at once...or you can separate this change out into a separate PR
There was a problem hiding this comment.
Right, this is ready. Let me know when you close and release that one, and Ill integrate it in after after that. I hope I understood you correctly
There was a problem hiding this comment.
@ryanjbaxter build has passed over there, FYI
There was a problem hiding this comment.
Its merged, the build should only take a few minutes before snapshots are published
| List<MapPropertySource> list = source.getPropertySources().stream() | ||
| .filter(p -> p instanceof MapPropertySource).map(x -> (MapPropertySource) x).toList(); | ||
| result.addAll(list); | ||
| source.getPropertySources().forEach(x -> { |
There was a problem hiding this comment.
this is so much easier to read, I am really sorry it did not occur to me when I was here in this code path before
| <suppress files=".*ConfigurationWatcherApplication\.java" checks="HideUtilityClassConstructor"/> | ||
| <suppress files=".*DiscoveryServerApplication\.java" checks="HideUtilityClassConstructor"/> | ||
| <suppress files=".*KubernetesConfigServerApplication\.java" checks="HideUtilityClassConstructor"/> | ||
| <suppress files=".*NormalizedSource\.java" checks="WhitespaceAfter" /> |
There was a problem hiding this comment.
if we upgrade formatter plugin, we do not require this one anymore
|
@ryanjbaxter let's see if I get lucky :) one more to look at please? :) |
|
@ryanjbaxter ready. |
3 participants
No description provided.