This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Added logging to AWSParameterStorePropertySource #529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cschroed-usgs Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
According to https://cla.pivotal.io/about#obvious-fixes , contributions of "Logging messages or debug output" don't require signing a CLA. |
|
@pivotal-issuemaster This is an Obvious Fix |
|
@cschroed-usgs Thank you for signing the Contributor License Agreement! |
|
I signed the CLA anyway because I'm a US federal employee and the same page says I should.
|
maciejwalkowiak
suggested changes
May 31, 2020
| @@ -61,6 +61,7 @@ public void init() { | |||
|
|
|||
| @Override | |||
| public Object getProperty(String name) { | |||
| logger.trace("getting property: " + name); | |||
There was a problem hiding this comment.
Suggested change
| logger.trace("getting property: " + name); | |
| logger.trace("Getting property: {}", name); |
| @@ -69,6 +70,7 @@ private void getParameters(GetParametersByPathRequest paramsRequest) { | |||
| .getParametersByPath(paramsRequest); | |||
| for (Parameter parameter : paramsResult.getParameters()) { | |||
| String key = parameter.getName().replace(context, "").replace('/', '.'); | |||
| logger.debug("setting property: " + key); | |||
There was a problem hiding this comment.
Suggested change
| logger.debug("setting property: " + key); | |
| logger.debug("Setting property: {}", key); |
maciejwalkowiak
added
component: parameter-store
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
May 31, 2020
Closes spring-atticgh-529 Fixes spring-atticgh-509 Fixes spring-atticgh-527 Co-authored-by: Maciej Walkowiak <[email protected]>
tmnuwan12
pushed a commit
to tmnuwan12/spring-cloud-aws
that referenced
this pull request
Jun 7, 2020
Closes spring-atticgh-529 Fixes spring-atticgh-509 Fixes spring-atticgh-527 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
Closes spring-atticgh-529 Fixes spring-atticgh-509 Fixes spring-atticgh-527 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
Closes spring-atticgh-529 Fixes spring-atticgh-509 Fixes spring-atticgh-527 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
Closes spring-attic#529 Fixes spring-attic#509 Fixes spring-attic#527 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
Closes spring-attic#529 Fixes spring-attic#509 Fixes spring-attic#527 Co-authored-by: Maciej Walkowiak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #509 and #527
public domain