Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Add trace or debug level logging of property names to Parameter Store #527

Closed
cschroedl-gov opened this issue Feb 21, 2020 · 0 comments
Closed
Labels
component: parameter-store Parameter Store integration related issue status: waiting-for-triage An issue we've not yet triaged
Milestone

Comments

@cschroedl-gov
Copy link
Contributor

cschroedl-gov commented Feb 21, 2020

Is your feature request related to a problem? Please describe.
Troubleshooting integrations between applications that use Spring Cloud and AWS Parameter Store can be difficult.

Describe the solution you'd like
Adding trace logging that prints the names of properties registered from AWS Parameter Store can help developers troubleshoot integration problems.

Describe alternatives you've considered
I've considered contributing logging to the upstream aws-sdk-java project, but it appears the associated classes are generated and therefore are not suitable for adding custom logging.

Additional context
We probably shouldn't log the value of the property because some could be secrets.
This is related to #509. Both focus on the class org.springframework.cloud.aws.paramstore.AwsParamStorePropertySource. This issue focuses on when the properties are registered (the getParameters method) and the other issue focuses on when they are read (the getProperty method).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 21, 2020
@maciejwalkowiak maciejwalkowiak added the component: parameter-store Parameter Store integration related issue label May 29, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue May 31, 2020
@maciejwalkowiak maciejwalkowiak added this to the 2.2.3 milestone Jun 1, 2020
tmnuwan12 pushed a commit to tmnuwan12/spring-cloud-aws that referenced this issue Jun 7, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: parameter-store Parameter Store integration related issue status: waiting-for-triage An issue we've not yet triaged
Development

No branches or pull requests

3 participants