Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Add support for import configuration via spring.config.import for Secrets Manager #655

Closed
eddumelendez opened this issue Sep 13, 2020 · 0 comments
Closed

Add support for import configuration via spring.config.import for Secrets Manager #655

eddumelendez opened this issue Sep 13, 2020 · 0 comments
Assignees
@eddumelendez
Labels
component: secrets-manager Secrets Manager integration related issue type: feature A new feature
Milestone
2.3

Comments

@eddumelendez
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Read Supporting Additional Locations https://spring.io/blog/2020/08/14/config-file-processing-in-spring-boot-2-4

Describe the solution you'd like
Use aws-secretsmanager: as a prefix

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@eddumelendez eddumelendez added type: feature A new feature component: secrets-manager Secrets Manager integration related issue labels Sep 13, 2020
@eddumelendez eddumelendez added this to the 2.3 milestone Sep 14, 2020
@eddumelendez eddumelendez self-assigned this Sep 14, 2020
eddumelendez added a commit to eddumelendez/spring-cloud-aws that referenced this issue Nov 13, 2020
@eddumelendez
Add aws-secretsmanager: prefix config import
3b09628 
In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was
added. This commit introduces the prefix `aws-secretsmanager:` which
will resolve the values given the configuration properties supported
by secrets manager integration. Also, if keys are added after the
prefix then just these will be resolved.

Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or
`aws-secretsmanager:my-secret-key;my-anoter-secret-key`

Closes spring-atticgh-655
@eddumelendez eddumelendez mentioned this issue Nov 13, 2020
Merged
eddumelendez added a commit to eddumelendez/spring-cloud-aws that referenced this issue Nov 13, 2020
@eddumelendez
Add aws-secretsmanager: prefix config import
dfdc5c9 
In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was
added. This commit introduces the prefix `aws-secretsmanager:` which
will resolve the values given the configuration properties supported
by secrets manager integration. Also, if keys are added after the
prefix then just these will be resolved.

Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or
`aws-secretsmanager:my-secret-key;my-anoter-secret-key`

Closes spring-atticgh-655
@maciejwalkowiak maciejwalkowiak mentioned this issue Nov 24, 2020
Closed
maciejwalkowiak added a commit that referenced this issue Dec 8, 2020
@maciejwalkowiak
Merge remote-tracking branch 'origin/2.3.x' into gh-655-polish2
fb4fcb5
maciejwalkowiak added a commit to awspring/spring-cloud-aws that referenced this issue Dec 19, 2020
@eddumelendez @maciejwalkowiak
Add aws-secretsmanager: prefix config import (spring-attic/spring-clo…
13906a8 
…ud-aws#721)

In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was
added. This commit introduces the prefix `aws-secretsmanager:` which
will resolve the values given the configuration properties supported
by secrets manager integration. Also, if keys are added after the
prefix then just these will be resolved.

Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or
`aws-secretsmanager:my-secret-key;my-anoter-secret-key`

Closes spring-attic/spring-cloud-aws#655
Closes spring-attic/spring-cloud-aws#515

Co-authored-by: Maciej Walkowiak <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eddumelendez eddumelendez

Labels
component: secrets-manager Secrets Manager integration related issue type: feature A new feature
Milestone
2.3
Development

No branches or pull requests
1 participant
@eddumelendez