-
Notifications
You must be signed in to change notification settings - Fork 369
Allow adding any arbitrary AWS Secrets Manager secrets #515
Comments
@tvrmsmith just so that I understand it correctly - these additional secrets would contains raw values and everything after prefix ( |
I think this link can be useful to understand the proposal. @tvrmsmith is what you meant? |
In case of RDS password I would like us to use this library in 3.0 https://github.com/aws/aws-secretsmanager-jdbc. I have it working in the prototype (... and made video about it how to use this library ;-) https://www.youtube.com/watch?v=gIbr6-AR6T8) |
Instead of an array of strings, maybe we should be a little more flexible and allow users to configure the desired name as well? I think we're going to hit a wall if we only depend on the library to interpret the secret name from the path. Maybe like aws:
secretsmanager:
additional-secrets:
secret1:
path: /secret/secret1
different.name:
path: /secret/secret2 and then I would be able to pull the secret from |
Agreed with @nhomble. I have a similar implementation of this via a |
…ud-aws#721) In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-secretsmanager:` which will resolve the values given the configuration properties supported by secrets manager integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or `aws-secretsmanager:my-secret-key;my-anoter-secret-key` Closes spring-attic/spring-cloud-aws#655 Closes spring-attic/spring-cloud-aws#515 Co-authored-by: Maciej Walkowiak <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
It would be great if we could add additional AWS Secrets Manager secrets as property sources. Currently, I'd like to use the RDS secrets feature as well as other secrets, but the current way of adding secrets makes it difficult to do this.
It could be configured something like:
The text was updated successfully, but these errors were encountered: