Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/split/alternative.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def initialize(name, experiment_name)
@name = name
@weight = 1
end
p_winner = 0.0
@p_winner = 0.0
end

def to_s
Expand Down Expand Up @@ -122,7 +122,7 @@ def z_score(goal = nil)
# can't calculate zscore for P(x) > 1
return 'N/A' if p_a > 1 || p_c > 1

z_score = Split::Zscore.calculate(p_a, n_a, p_c, n_c)
Split::Zscore.calculate(p_a, n_a, p_c, n_c)
end

def extra_info
Expand Down
2 changes: 1 addition & 1 deletion lib/split/combined_experiments_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def find_combined_experiment(metric_descriptor)
raise(Split::InvalidExperimentsFormatError, 'Invalid descriptor class (String or Symbol required)') unless metric_descriptor.class == String || metric_descriptor.class == Symbol
raise(Split::InvalidExperimentsFormatError, 'Enable configuration') unless Split.configuration.enabled
raise(Split::InvalidExperimentsFormatError, 'Enable `allow_multiple_experiments`') unless Split.configuration.allow_multiple_experiments
experiment = Split::configuration.experiments[metric_descriptor.to_sym]
Split::configuration.experiments[metric_descriptor.to_sym]
end
end
end
2 changes: 1 addition & 1 deletion lib/split/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def ab_finished(metric_descriptor, options = {:reset => true})

def ab_record_extra_info(metric_descriptor, key, value = 1)
return if exclude_visitor? || Split.configuration.disabled?
metric_descriptor, goals = normalize_metric(metric_descriptor)
metric_descriptor, _ = normalize_metric(metric_descriptor)
experiments = Metric.possible_experiments(metric_descriptor)

if experiments.any?
Expand Down