When loading active_experiments, it should not look into user's 'finished' keys #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
All calls for experiments keys on User should be gated with
keys_without_finished. This method filters out all 'finished' keys.The issue happened because
active_experimentswas loading alluser.keys. And when callingkey_without_versionmethod with a 'finished' key with more than 9 versions. Example:It would end up overriding the value of an experiment with the 'exp:11:finished' value from the Storage, which is always 'true'.