Skip to content

Shdict cas #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2016
Merged

Shdict cas #1

merged 2 commits into from
May 11, 2016

Conversation

splitice
Copy link
Owner

No description provided.

@splitice splitice merged commit eb88b62 into splitice:master May 11, 2016
splitice pushed a commit that referenced this pull request Apr 1, 2022
@chipitsine @rainingmaster
src/ngx_http_lua_ssl_certby.c: fix possible null pointer dereference …
138c1b9 
…found by coverity

   deref_ptr: Directly dereferencing pointer c.
419    if (c->addr_text.len) {
420        p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text);
421        len -= p - buf;
422        buf = p;
423    }
424
   CID 149837 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
425    if (c && c->listening && c->listening->addr_text.len) {
426        p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text);
427        /* len -= p - buf; */
428        buf = p;
429    }
splitice pushed a commit that referenced this pull request Apr 1, 2022
@chipitsine
chore: fix possible null pointer dereference found by Coverity (openr…
88a52c4 
…esty#1846)

734    buf = p;
735
   deref_ptr: Directly dereferencing pointer c.
736    if (c->addr_text.len) {
737        p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text);
738        len -= p - buf;
739        buf = p;
740    }
741
   CID 149839 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
742    if (c && c->listening && c->listening->addr_text.len) {
743        p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text);
744        /* len -= p - buf; */
745        buf = p;
746    }
splitice pushed a commit that referenced this pull request Apr 1, 2022
@zhuizhuhaomeng
bugfix: fixed memcpy param overlap detected by asan.
3f1c683 
==openresty==70603==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x621000001500,0x621000002181) and [0x62100000187f, 0x621000002500) overlap
    #0 0x7f3db1899ffe  (/lib64/libasan.so.5+0x99ffe)
    #1 0x9da926  (/usr/local/openresty-debug/nginx/sbin/nginx+0x9da926)
    #2 0x9dd1a1  (/usr/local/openresty-debug/nginx/sbin/nginx+0x9dd1a1)
    openresty#3 0x4c89c6  (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
    openresty#4 0x5d1e4e  (/usr/local/openresty-debug/nginx/sbin/nginx+0x5d1e4e)
    openresty#5 0x4c89c6  (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
    openresty#6 0x5b8583  (/usr/local/openresty-debug/nginx/sbin/nginx+0x5b8583)
    openresty#7 0x4c89c6  (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
    openresty#8 0x4b4419  (/usr/local/openresty-debug/nginx/sbin/nginx+0x4b4419)
    openresty#9 0x427f16  (/usr/local/openresty-debug/nginx/sbin/nginx+0x427f16)
    openresty#10 0x7f3daff27554  (/lib64/libc.so.6+0x22554)
    openresty#11 0x42d537  (/usr/local/openresty-debug/nginx/sbin/nginx+0x42d537)
splitice pushed a commit that referenced this pull request May 25, 2022
@chipitsine
optimize: fix potential null pointer dereference found by coverity (o…
b91221b 
…penresty#2051)

deref_ptr: Directly dereferencing pointer ctx.
1143    *ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module);
    CID 258020 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking ctx suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1144    if (ctx == NULL) {
1145        return NGX_HTTP_LUA_FFI_NO_REQ_CTX;
1146    }
splitice pushed a commit that referenced this pull request May 25, 2022
@zhuizhuhaomeng
bugfix: tctx.pool is double freed. (openresty#2049)
0ac2ab2 
    } else if (tctx.pool) {
   	
CID 251579 (#1 of 1): Use after free (USE_AFTER_FREE)
18. deref_arg: Calling ngx_destroy_pool dereferences freed pointer tctx.pool.
762        ngx_destroy_pool(tctx.pool);
763    }
764}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splitice @doujiang24