Fix URLs in search results #14058
Open
Fix URLs in search results #14058
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
reviewed
Nov 18, 2025
| } | ||
| let linkEl = listItem.appendChild(document.createElement("a")); | ||
| linkEl.href = linkUrl + anchor; | ||
| const encodedLinkUrl = linkUrl.split("/").map(encodeURIComponent).join("/"); |
Contributor
There was a problem hiding this comment.
Is it possible for linkUrl to contain other components that we would not want to URL-encode? (for example, protocol scheme - http://, or similar?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR ensures that URLs in search results are properly encoded.
Previously, search result URLs containing characters such as
#or?were not encoded correctly.This change adds URL encoding in the
_displayItemof search results to fix this issue.References