Log differences in configuration from the pickled environment #12949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
Oct 3, 2024
Closed
picnixz
reviewed
Oct 7, 2024
# Conflicts: # CHANGES.rst # sphinx/environment/__init__.py
|
Sorry I never responded, seems like it should help, thanks @AA-Turner ! |
|
No worries, thank you for the idea and discussion @larsoner. A |
chrisjsewell
added a commit
to useblocks/sphinx-needs
that referenced
this pull request
Oct 28, 2024
Since sphinx-doc/sphinx#12949 it has become more apparent that sphinx detects some configuration values as changed when they have not. This fixes most of these by merging user defined config with built-in defaults earlier in the processing. The only thing is does not fix is config altered by adding services. This is difficult, since services are stored on the `env`, which is not initialised until agter the config is checked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @larsoner
This is an attempt towards #12741, displaying what has changed in the config between the pickled environment and
conf.py.This should have a test and CHANGES entry before merge, but interested in your thoughts.
A